Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always visible feature not working correctly with new video page UI #951

Closed
ParticleCore opened this issue Mar 1, 2024 · 1 comment
Closed
Labels
Milestone

Comments

@ParticleCore
Copy link
Owner

The new video page UI has some changed elements that are causing the feature to malfunction, even if it is turned off.

Seems like some crucial elements are missing from the page which the feature relies on to work properly.

@ParticleCore ParticleCore added this to the 2.0.6 milestone Mar 1, 2024
@ParticleCore
Copy link
Owner Author

Two checks were not including the setting state before making changes, this then allowed the chain of events to skip crucial steps and make changes:

if (!document.fullscreenElement && window.location.pathname === "/watch" && parentRects.bottom < parentRects.height * .5) {

if (!isAlwaysVisible() || !moviePlayer) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 participant