Issue with nav bar width in super theater mode

[Piripe]

The nav bar has a static size in super theater mode.

I'm using Firefox 124 with Iridium 2.0.9.

Example screenshots:

[ParticleCore]

Hi, sorry about this but can you clarify what you mean? I am having a hard time understanding what you're explaining to me.

[Piripe]

Currently, when I resize the window, the nav bar keeps the same size. So when I resize the window to a smaller width, the nav bar overflows (and when I resize to a larger width, the nav bar doesn't take up the whole width of the window)

[ParticleCore]

Oh, now I get it, it happens when resizing the window. I will check it out and see what is happening.

[ParticleCore]

I am not able to replicate the issue, I tried opening a normal video in super theater and resizing the window, the top bar width adjusts correctly, and doing the same for a video with chat, and navigating to a video without chat afterwards.

Can you explain which steps I need to follow to be able to trigger the issue on my end?

[ParticleCore]

Actually, checking your second screenshot shows an odd thing, a scrollbar (I am assuming that's a scrollbar) that is not the normal one:

vs the normal scrollbar in the previous screenshot

Seems like the window is being resized in a way that is not like my window. Can you take a screenshot of the entire browser window when resized?

[ParticleCore]

On a second thought, it looks like you have some other YouTube extensions

so let's rule out the possibility of this being a problem caused by Iridium.

Test the issue with Iridium disabled (remember to refresh YouTube), does the issue still happen?

Test the same issue with Iridium enabled, but all other extensions disabled (including Stylus, for example), does the issue still happen?

[Piripe]

The scrollbar in the first screenshot is a scrollbar from the video I was watching, not my browser's scrollbar, and the scrollbar in the second screenshot is the Firefox's scrollbar, my actual browser scrollbar.

And yeah, I have a lot of extensions. I tried in a private window with only Iridium enabled. And the issue persists.
I also have more precise steps now, after trying to reproduce the issue.
It happens when closing the live (or VOD) chat

Here's the nav bar with the chat open:

And here's the nav bar without the chat:

And while trying to reproduce the issue, I found a conflict with another extension but I don't know which one, I'll make an issue if I haven't found a solution and if I have more info about it.dd

[ParticleCore]

Perfect, thank you for the steps, that was exactly what I needed. I will fix this asap.

[ParticleCore]

Logic excludes updates when the chat is no longer visible:

Iridium/src/firefox/js/background-inject.js

Line 993 in dfaa5df

&& document.getElementById("chat")?.["isHiddenByUser"] !== true

Will have to reset the size to normal behavior when that happens, currently that scenario is not being taken into account.

[ParticleCore]

@Piripe I have not forgotten about this issue, it will be resolved along with #976 which is a bigger one and was discovered thanks to this one you opened. I intend to have a new version for these fixes by the end of this week.

[ParticleCore]

Issue should be resolved, seems like during my previous implementations with that feature the reset portion was still using old code.

9d5a655#diff-64234f092fc31df67bfb1b6c9d2ae604e01f21ebc0a378a0a390f359b335e3a4R1046-R1053

I'll be pushing the new version with this fix today.