Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move construct method to base class #3136

Open
blnicho opened this issue Feb 13, 2024 · 0 comments
Open

Move construct method to base class #3136

blnicho opened this issue Feb 13, 2024 · 0 comments

Comments

@blnicho
Copy link
Member

blnicho commented Feb 13, 2024

Summary

As discussed here there is repeated code (e.g., the oft-repeated debug logging, the logic to skip-if-constructed, and now anonymous set handling) in many of the component construct methods. We should move this code to a base class construct method and have it call a _construct_impl() that is overridden on the derived classes. This would reduce a lot of repeated code and shouldn't impact performance significantly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant