Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error in generate_strongly_connected_components instead of asserting #3305

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Raise error in generate_strongly_connected_components instead of asserting #3305

wants to merge 5 commits into from
+27 −1

Conversation

Robbybp
Copy link
Contributor

@Robbybp Robbybp commented Jun 29, 2024

Fixes #3297

More useful error message.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
@blnicho blnicho self-requested a review July 2, 2024 19:02
@codecov Codecov
Copy link

codecov bot commented Jul 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.49%. Comparing base (f5e6f32) to head (fe79414).
Report is 22 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3305      +/-   ##
==========================================
- Coverage   88.50%   88.49%   -0.01%     
==========================================
  Files         868      868              
  Lines       98427    98430       +3     
==========================================
- Hits        87112    87107       -5     
- Misses      11315    11323       +8
Flag Coverage Δ
linux 86.30% <100.00%> (+<0.01%) ⬆️
osx 75.61% <100.00%> (-0.01%) ⬇️
other 86.50% <100.00%> (+<0.01%) ⬆️
win 83.81% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@Robbybp @mrmundt @jsiirola @pyomo-autotest