Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency version number in setup.py #38

Closed
R1j1t opened this issue Dec 17, 2020 · 3 comments · Fixed by #52
Closed

dependency version number in setup.py #38

R1j1t opened this issue Dec 17, 2020 · 3 comments · Fixed by #52
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@R1j1t
Copy link
Owner

R1j1t commented Dec 17, 2020

This will help prevent code break when some user has an old dependency.

Considerations: Will need to check the lowest version to minimise the unnecessary updates

@R1j1t R1j1t created this issue from a note in Code Dashboard (To do) Dec 17, 2020
@R1j1t R1j1t added documentation Improvements or additions to documentation good first issue Good for newcomers labels Dec 17, 2020
@R1j1t R1j1t moved this from To do to In progress in Code Dashboard Dec 21, 2020
@R1j1t R1j1t moved this from In progress to To do in Code Dashboard Dec 21, 2020
@AlvinKuruvilla
Copy link

AlvinKuruvilla commented Feb 3, 2021

Hi I would like to take up this issue, how exactly would we go about checking minimum versions?

@R1j1t
Copy link
Owner Author

R1j1t commented Feb 4, 2021

Thanks @AlvinKuruvilla for your contribution! There is no restriction to have the lowest version possible as dependency. You can check if all the tests pass for the last major release (1.x or 2.x etc) for the core dependency.

install_requires=["torch", "editdistance", "transformers", "spacy"],

If the tests fail then maybe will have to check the required minor version based on the test result.

@R1j1t R1j1t moved this from To do to Done in Code Dashboard Feb 17, 2021
@R1j1t R1j1t linked a pull request Feb 17, 2021 that will close this issue
5 tasks
@R1j1t R1j1t closed this as completed Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
2 participants