Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integration tests to use vcrpy #770

Open
ngfgrant opened this issue Jun 28, 2019 · 1 comment
Open

Update integration tests to use vcrpy #770

ngfgrant opened this issue Jun 28, 2019 · 1 comment

Comments

@ngfgrant
Copy link
Contributor

CONTEXT

Our Integration tests are pretty slow - taking around 15 minutes to complete each full run. This is a pain for development and also during deployments.

We also have another issue as in order to allow integration tests to run from contributors external to Cloudreach we would need to allow access to our sceptre test AWS account which is used during our circleci builds.

We could utilise a library like vcr.py to store the results of CloudFormation API requests and for the majority of test to be run against these during branch development. As stated in the vcr project this would give us:

  • The ability to work offline
  • Completely deterministic tests
  • Increased test execution speed

but importantly it would also allow external contributors PRs to run the integration tests which would make life easier for the maintainers. Currently, we have to create a branch and merge the external PR into it in order to trigger the build in circleci - or of course clone it and run locally.

DONE WHEN

Firstly, we should evaluate whether we can indeed utilise VCR.py and if so then implement it by decorating the existing integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment