Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few suggestions #34

Open
SodaWithoutSparkles opened this issue Apr 5, 2022 · 6 comments
Open

A few suggestions #34

SodaWithoutSparkles opened this issue Apr 5, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@SodaWithoutSparkles
Copy link

SodaWithoutSparkles commented Apr 5, 2022

  1. Instruct users to change search path when no lrc was found

  2. Highlight current line instead of blinking green.

  3. Preserve empty lines when editing existing lrc files

  4. Preview more lines

  5. In addition to the + sign next to each line, a big timing button at the corner would be great. That way you could focus on timestamping the music instead of worrying clicking the wrong button nearby

  6. Global offset when editing existing LRC files. That one is simple, just add a [offset:x] in before the lyric. Then just import-export cycle it. If lyric is faster then song then add a negative offset, i.e. the line marked at 00:15.00 is actually at 00:05.00 then [offset:-10000]

  7. Auto-scroll synced lyrics

@Spikatrix
Copy link
Owner

Thanks for the suggestions!

1 and 2: Makes sense now that I think about it.

3: I'm not sure I understand this one. LRC Editor does preserve empty lines with a timestamp. Can you please provide an example of what you mean by this?

4: I'm guessing this is #14

5: Initially I thought you were saying that you wanted a bigger + button but I'm not sure what the third button is about. What would happen when you press it? Also, I don't want to add too many buttons since it will get confusing for users. The play button for every line is useful for a lot of users and hence I think it should stay there.

6: This is something I've thought about in the past but there's already a batch edit feature which can pretty much achieve the same result. Hold on any lyric line and once it's selected, tap the select all button in the toolbar at the top and then click on the batch edit button. You can then set the offset to modify the timestamps of the selected lyrics which basically achieves the same result as [offset: x].

7: This is something I've thought about as well. Some users might find it annoying that the UI scrolls when they don't want it to. I guess I could add a toggle button to enable/disable auto-scroll in that case.

@Spikatrix Spikatrix added the enhancement New feature or request label Apr 6, 2022
@SodaWithoutSparkles
Copy link
Author

SodaWithoutSparkles commented Apr 6, 2022

3:

Alan Walker - Alone.lrc

[01:37.90]At least we are together

[01:40.90]I know I am not alone

After importing into LRC editor, the line break disappeared. If you then export this happens:

Alan Walker - Alone - Edited.lrc

[01:37.90]At least we are together
[01:40.90]I know I am not alone

4: its not the same, its like having the currently timestamping line in the middle of the screen. That way you can see next (few) line(s). Especially when timestamping song with a language you are unfamiliar with, you need the next few lines to know if you are lagging behind. Also, in the current layout, a empty line would block you from seeing the next line.

5: the play button is useful. I mean a button, when you press it, it finds the first line which dont have time and mark it.

6: wait, theres a batch edit function? maybe add a instruction page to tell users, dont assume they know the function

@Spikatrix
Copy link
Owner

3: Thanks for the example. I can't think of why you would want this to be honest as blank lines have no effect. Also, considering that lines may not be ordered in an lrc file and also that there may be condensed lyrics such as [1:37.90][2:12.20][2:47.20]At least we are together, I don't think this can be done.
If you need a blank line in the lyrics, add a line with just the timestamp. LRC Editor will be able to track it with the help of the timestamp.

4: I get it now, good suggestion.

5: I understand what you mean but I'm not sure if it's a good idea as users might wish to skip certain lines and also because I'm not sure where to place such a button without making the UI too cluttered. I believe the '+' button is sufficient as it's there on every line and you can choose which lines to add and which ones to ignore. I might make the '+' button a bit bigger so that it's easier not to miss it.

6: I agree, it isn't obvious that there would be options shown on hold (Did you know you could hold on items from the home page too for renaming/deleting LRC files?). But on the other hand, LRC Editor is already small and easy to use and adding instructions on each and every option would be a little too much spoon-feeding IMO. I did try adding a ripple animation on every item in the editor page but that ended up interfering with other things resulting in a weird animation overall so I ended up scrapping it.

@SodaWithoutSparkles
Copy link
Author

SodaWithoutSparkles commented Apr 7, 2022

3: Wait, you could have multiple timestamps in one line?

5: Why would users want to skip lines? Or, a toggle switch to enable/disable function. Maybe timestamp the line after last timestamped one?

6: Maybe on first startup, add a welcome screen that directs them to a introduction to all the basics. On the final page, add a link to a detailed manual. The detailed manual can be accessed from the three-dot button on top right.

@Spikatrix
Copy link
Owner

3: Yes, it's called condensed lyric format. It's not as widely used as the standard format but I've seen a couple of them out in the wild and some music players do support them as well. LRC Editor can read them but once exported, everything will be in the standard format with one timestamp per line.

5: In case the lyrics they've copied has unnecessary lines in them or one or more blank lines that the user wishes to not add into the final LRC file, they might want to skip them.

6: Hmm, I'll think about it.

@SodaWithoutSparkles
Copy link
Author

3: so its not a standard thing. Thanks!

5: in said case they would deleted them when they paste the lyrics anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
2 participants