Support for React 17

[hichemfantar]

React 17 causes this warning:

findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of Transition which is inside StrictMode. Instead, add a ref directly to the element you want to reference

Disabling strict mode doesn't fix the issue.

[Steveeeie]

Thanks for raising this, I will resolve as soon as possible.

[hichemfantar]

This might help with fixing the issue:
reactjs/react-transition-group#668

[Steveeeie]

@hichemfantar I'm struggling to reproduce the error.

I have successfully updated the advanced demo to use StrictMode and version 17 of React: https://codesandbox.io/s/advanced-react-page-transition-demo-z8hmd.

I have also successfully updated the basic demo to use StrictMode and version 17 of React:
https://codesandbox.io/s/basic-react-page-transition-demo-rk0uv

[hichemfantar]

Weird, It's working now. Maybe it's because I'm using node 12 now instead of 14 like I was before.
I'll test it again with node 14 and get back to you asap.

[hichemfantar]

Ok it seems like It's working on both now. Have no idea what I messed up previously.
Anyway, Now the warning appears in the console in strict mode however the app continuers to function normally despite the warning, also disabling strict mode makes the warning go away.

[Steveeeie]

Thank you for looking into this for me.

I'm seeing the console warning too, i will try to resolve it this week.

[hichemfantar]

Cool man, looking forward to the fix!

[antonnystedt]

I still get this error.

[hichemfantar]

Apparently this is an issue with react-transition-group
@Steveeeie can't fix it unless a fork is made of react-transition-group with the new API or this package gets rewritten on top of a different animation library.

[hichemfantar]

Apparently there's no official fix for this and all the workarounds have certain pitfalls.
I believe it would be better to port the library to Framer Motion.
These are some nice resources:
https://stackoverflow.com/questions/70239122/react-router-dom-v6-with-framer-motion-v4
https://www.geeksforgeeks.org/page-transition-in-react-js-using-framer-motion/
https://www.framer.com/docs/guide-upgrade/#50

[Steveeeie]

That's not a bad shout. I have a lot of experience with Framer Motion. Switching to it would remove a lot of the configuration and make the whole thing a lot more plug and play.

[hichemfantar]

Looking forward to the switch to framer motion, I believe you'll bump this library to the next major version since it would probably be incompatible with the previous release.
I don't have a lot of experience with framer motion but I'll be glad to help in anyway i can.

[Steveeeie]

See: #33