Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw a warning for broken room order entries #1804

Open
nkrapivin opened this issue Jun 7, 2024 · 0 comments
Open

Throw a warning for broken room order entries #1804

nkrapivin opened this issue Jun 7, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@nkrapivin
Copy link
Contributor

Which component should be improved?

Lib

Describe your feature suggestion in more detail

It's possible to specify a duplicate room in the RoomOrderNodes in a YYP file, leading to some very cursed results within the game and ModTool.

For example:

  "RoomOrderNodes": [
    {"roomId":{"name":"Room1","path":"rooms/Room1/Room1.yy",},},
    {"roomId":{"name":"Room2","path":"rooms/Room2/Room2.yy",},},
    {"roomId":{"name":"Room2","path":"rooms/Room2/Room2.yy",},},
  ],

will actually load, but the room will be duplicated in the asset list:

image

I don't know if it's a bug or not, technically there is only one room asset, but multiple room order nodes for it, this is highly cursed and is a GameMaker bug but it's technically allowed as the game builds and runs, so maybe ModTool should catch such cases and warn the user?

@nkrapivin nkrapivin added the enhancement New feature or request label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
1 participant