RtspServer folder is empty into the zip file

[CyberGuerro]

Describe Your Environment

• Version of ZoneMinder 1.36.0
• Full name and version of OS: Gentoo

/dep/RtspServer folder is empty and build process fails.
In the repository that folder is a sim-link and I think that doesn't like when you create a zip file.

[connortechnology]

I think you havn't done
git submodule init
git submodule update --init --recursive

however... it should not be a symlink.

[CyberGuerro]

I'm sorry, but my installation package get the sources from this url:
https://github.com/ZoneMinder/zoneminder/archive/1.36.0.tar.gz (try it from your browser)
and the file downloaded has folder empty.
I think that operations you suggest can't be done by Package Manager (if yes how?) but only a real user. Package Manager wait for that archive file is autoconsistent.

[SteveGilvarry]

GitHub releases does not support sub modules so that file has always been missing any sub modules. Somewhat annoying, @connortechnology in the past we added a file for completeness. https://github.community/t/create-release-that-contains-submodule/1329/36

[SteveGilvarry]

https://stackoverflow.com/questions/52907659/build-a-project-containing-git-submodules-from-source-package-of-a-github-releas

[connortechnology]

I think the real issue here is that we should still build without it.

@Carbenium you are the resident expert on cmake I think. Can you take a look and just not build the rtspserver parts if rtspserver dir is unpopulated?

[Carbenium]

This certainly can be done.
One thing to consider: IMHO if something is missing to build an activated option (ZM_NO_RTSPSERVER CMake option exists to disable this feature), the build should fail.
So instead of just silently (or even with a CMake warning) deactivate this feature when the folder is empty, we should consider to turn this into a CMake error and document there the appropriate steps (either set ZM_NO_RTSPSERVER or populate the folder).

What's your take on this @connortechnology ?

[connortechnology]

I would say yeah, if the feature was explicitly turned on, then give an error. If not explicitly turned on then it should give some output that the feature is disabled. We do this for various libraries already.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.