-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onvif probe fail to detect profiles #3767
Comments
Thanks for opening your first issue here! Just a reminder, this forum is for Bug Reports only. Be sure to follow the issue template! |
same OS ubuntu 22.04.3 LTS, my camera onvif port is 8090, but i cant not check my camera at onvif network searching. so can we add the funtion that custom onvif IP and port ? |
Discovery (probe) is UDP broadcast. I guess your camera is not onvif if this is not found. Alternative is that you are not on same sub network or your router is not forwarding those packets |
Can we please get the output from zmonvif-probe.pl -v profiles? I don't see why a & in a url would be invalid... is it not utf8? Is that what you are saying? Technically we could try to sanitise the response before soap parsing... but this feels very wrong. |
Describe Your Environment
If the issue concerns a camera
Describe the bug
This is camera problem and you need same model (or some other model with same problem) in order to reproduce bug.
Anyway, this can be fixed in onvif error handling.
From main window choose "Add" and in monitor configuration window click on onvif.
I have tested camera behavior (new in onvif, not perl programmer) and have detected :
GetProfiles is working without problem
GetStreamUri crash because of broken response
(I am guessing "next" is reading both profiles and GetStreamUri)
The problem is because character "&" is not properly encoded in response and that onvif crash because xml is not valid.
I have intercepted GetStreamUriResponse after GetStreamUri and broken part is in Uri
tt:Urirtsp://10.10.10.10:554/user=admin_password=xxxxx=0_stream=0&onvif=0.sdp?real_stream</tt:Uri>
From my point of view solution would be to catch xml parse error, check raw output for malformed responses and try to parse response again. something like ... Replace("&", "&");
(Yes, I understand this is camera wrong response, not soap bug but looks like many camera models have same problem and this would be nice improvement to handle error and fix this error)
I am new in zoneminder and not linux programmer but have a lot experience in IT so fell free to contact me for more details if this is not clear.
Camera is identified from broadcast with two lines for two soap version
I2P3C-model@<1.1.1.1> using version 1.[1-2]
The text was updated successfully, but these errors were encountered: