Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding transaction history to the wallet #4

Open
aaroncox opened this issue May 24, 2017 · 1 comment
Open

Adding transaction history to the wallet #4

aaroncox opened this issue May 24, 2017 · 1 comment

Comments

@aaroncox
Copy link
Owner

Add a transaction history to the wallet to view previous transactions.

Notes:

  • Requires some sort of external data source/api, as currently I don't believe there's a way to filter only transactions in the steemd apis.
@arhag
Copy link

arhag commented May 25, 2017

Requires some sort of external data source/api, as currently I don't believe there's a way to filter only transactions in the steemd apis.

If you are running your own node you can set the filter-posting-ops option to true to make the account_history plugin only record a subset of the transactions. It is supposed to be the subset ignoring posting/commenting/voting and custom operations, but apparently it hasn't been updated to reflect many of the new operations that were added that I think really should not be filtered out, such as account_create_with_delegation_operation, claim_reward_balance_operation, and delegate_vesting_shares_operation. There are also older operations that weren't included which surprised me, such as convert_operation, withdraw_vesting_operation, and set_withdraw_vesting_route_operation. You would probably want to add the previous to the list in the transaction history for Vessel, perhaps along with account_witness_proxy_operation (since that is also a feature Vessel already supports), as well as a bunch of virtual operations such as: interest_operation, fill_convert_request_operation, fill_vesting_withdraw_operation, fill_transfer_from_savings_operation, and return_vesting_delegation_operation. Perhaps you would also want to track limit_order_create_operation, limit_order_create_operation2, limit_order_cancel_operation, and fill_order_operation to keep track of the account's internal market activity, or maybe just fill_order_operation since that is when an actual exchange of tokens happens (you could also use the get_open_orders API to calculate how much of the account's STEEM and SBD were tied up in open orders at the present time).

Whatever you decide to include or not include, the appropriate changes would need to be made in this function of the account_history plugin of the backend node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants