Unbalanced TFT_RD_LOW() / TFT_RD_HIGH() due to conditional assembly

[spiro-trikaliotis]

Hello,

since sporadically, I have some problems with my SPI communication on an esp8266 device, I was looking into the code to see if there are some unbalanced calls to TFT_RD_HIGH(), TFT_RD_LOW(), SPI_CS_LOW() and _HIGH(), and so on. You get the idea.

While I do not think this is related to my problem, from looking at the code, I believe that the TFT_RD_HIGH() here:

Adafruit-GFX-Library/Adafruit_SPITFT.cpp

Line 2178 in f542ec2

TFT_RD_HIGH(); // Read line HIGH

is not correctly balanced with its corresponding TFT_RD_LOW().

Why?
The TFT_RD_LOW is on line 2151, (

Adafruit-GFX-Library/Adafruit_SPITFT.cpp

Line 2151 in f542ec2

TFT_RD_LOW(); // Read line LOW

), before an #if defined(AVR). The TFT_RD_HIGH in line 2178 is inside the #else block of that #if. Thus, if AVR is defined, the TFT_RD_HIGH is not executed.

Unfortunately, I do not have an AVR with a corresponding TFT, so I cannot do some tests on my own.

My recommendation is to exchanges lines 2178 (

Adafruit-GFX-Library/Adafruit_SPITFT.cpp

Line 2178 in f542ec2

TFT_RD_HIGH(); // Read line HIGH

) and 2179 (

Adafruit-GFX-Library/Adafruit_SPITFT.cpp

Line 2179 in f542ec2

#endif // end !__AVR__

), so the TFT_RD_HIGH() is outside if that #if / #else / #endif block.

Do you agree on this?

EDIT: If you agree on this, I can send a PR.