-
Notifications
You must be signed in to change notification settings - Fork 26.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
array-callback-return example corrected in Readme.md for issue #1806 #2072
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix all the linting errors.
However, the original issue doesn't actually have a clear solution yet, so a PR was premature.
Can you please check. I removed them sir. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not clear on why reduces are better examples than filters?
Reducers aren't better or less than filters, but I think for a newbie understanding the above example would be much simpler than the filter example as it clearly shows how an array is getting reduced and values returned and stored in a new array. |
There's already reduce examples above it; the purpose of the section is to talk about callbacks - showing different kinds of callbacks, like filter predicates, is useful. |
Fixes #1806