fix(material/autocomplete): Prevent Autocomplete overlap with outlined form-field label when overlay is positioned above #27714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kharazian
requested review from
devversion,
mmalerba and
crisbeto
as code owners
crisbeto
reviewed
Aug 27, 2023
crisbeto
reviewed
Aug 28, 2023
| * Calculate the vertical offset for the overlay when the input field has an outline appearance. | ||
| * In the outline appearance, the overlay should have extra space to display the label correctly. | ||
| */ | ||
| const outlineHeight = |
There was a problem hiding this comment.
This logic will measure the floating label height even if the form field isn't using the outlined appearance. This should be guarded with the hasOutline check since it has performance implications.
There was a problem hiding this comment.
Thank you for pointing out the need to optimize this logic. I've first checked _hasOutline() to enhance performance when measuring the floating label height in cases where the form field isn't using the outlined appearance.
| @@ -830,9 +830,25 @@ export class MatAutocompleteTrigger | |||
| // the opposite end has rounded corners. We apply a CSS class to swap the | |||
| // border-radius based on the overlay position. | |||
| const panelClass = this._aboveClass; | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Should use the // style comments.
There was a problem hiding this comment.
Thank you, I've made the correction.
…d label when overlay above Fixes by preventing Autocomplete overlap with outlined form-field label when overlay is positioned above. Implemente a function to calculate the necessary vertical offset for outlined appearance, ensuring label legibility. Fixes angular#27476
…ing parent form field Fixes angular#27476
…he outline appearance Fixes angular#27476
kharazian
force-pushed
the
calculate-overlay-offset-for-outlined-input-fields
branch
from
c6f883c
to
8f1b1b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed by preventing Autocomplete overlap with outlined form-field label when overlay is positioned above. Implemented a function to calculate the necessary vertical offset for outlined appearance, ensuring label legibility.
Fix #27476