Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug Report: Wrong Message When Changing Email on Console #975

Open
2 tasks done
ItzNotABug opened this issue Mar 17, 2024 · 9 comments
Open
2 tasks done

🐛 Bug Report: Wrong Message When Changing Email on Console #975

ItzNotABug opened this issue Mar 17, 2024 · 9 comments
Labels
bug Something isn't working product / auth Fixes and upgrades for the Appwrite Auth

Comments

@ItzNotABug
Copy link
Contributor

👟 Reproduction steps

Assuming you have 2 different Email Addresses, each with an Account on Cloud.


  1. Go to second account
  2. Account > Edit Email Address
  3. Enter the Email Address of the First account > Enter password > Update
  4. Error - There was an error processing your request. Please check the inputs and try again.

The error should properly depict that the new Email Address already exists on Appwrite or connected to an Organization.

👍 Expected behavior

Show proper error message as mentioned above.

👎 Actual Behavior

Current shown error is not too clear regarding the actual error.

🎲 Appwrite version

Appwrite Cloud

💻 Operating system

Linux

🧱 Your Environment

No response

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

@ItzNotABug ItzNotABug added the bug Something isn't working label Mar 17, 2024
@MatthijsDV2004
Copy link
Contributor

Hi there, I would like to work on this issue, please.

@MatthijsDV2004
Copy link
Contributor

Nevermind this bug seems to have been fixed already - should be marked as complete / solved.

@stnguyen90 stnguyen90 self-assigned this Mar 29, 2024
@stnguyen90 stnguyen90 added the product / auth Fixes and upgrades for the Appwrite Auth label Mar 29, 2024
@stnguyen90
Copy link
Contributor

@ItzNotABug, thanks for creating this issue! 🙏🏼 You mentioned:

The error should properly depict that the new Email Address already exists on Appwrite or connected to an Organization.

We actually don't want to say the email address already exists because that let's the user know someone has that email on the platform. As such, can this be closed?

@ItzNotABug
Copy link
Contributor Author

@stnguyen90,
The point for not really saying that the email already exists is valid but the current message still seems pretty vague. Even though an email might be in use, the current error says there's an error with the input [presumably frontend form].

We could instead use something or similar like -

  1. Unable to update email. Please ensure it is correct and not already in use.
  2. Unable to update email. Please ensure email address is yours and is correctly typed.
@stnguyen90
Copy link
Contributor

@gewenyu99, what are your thoughts on the copy of the error message?

@gewenyu99
Copy link

@stnguyen90 It's interesting because the solution LinkedIn, Facebook, etc use is actually just a captcha that blocks repeated attempts to snoop for emails.

I really want to be able to display a different response to the Console SDK vs Client/Server SDK.

For for, unable to update email is as far as we should go. Please ensure it is correct and not already in use. is basically saying it's in use. They can tell if it's a valid email they tried.

@stnguyen90
Copy link
Contributor

I really want to be able to display a different response to the Console SDK vs Client/Server SDK.

@gewenyu99, to do this, the Console needs to check the type (assuming the type is unique enough) and then show some custom message, ignoring the message from the API response.

@stnguyen90 stnguyen90 removed their assignment Apr 16, 2024
@gewenyu99
Copy link

@stnguyen90 Does this API exist for client? Doesn't it require a password? Maybe we just need to rate limit it?

@stnguyen90
Copy link
Contributor

Does this API exist for client? Doesn't it require a password? Maybe we just need to rate limit it?

@gewenyu99, yes, the update email endpoint requires a password. There must be a default rate limit on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working product / auth Fixes and upgrades for the Appwrite Auth
4 participants