Skip to content
This repository has been archived by the owner on Jan 4, 2023. It is now read-only.

Respect both no_reserve and reserve_unknown as potential reserve statuses #615

Open
sweir27 opened this issue Sep 22, 2016 · 0 comments
Open
Assignees

Comments

@sweir27
Copy link
Contributor

sweir27 commented Sep 22, 2016

This is related to: artsy/eigen#1835

Basically, in places like here:

enum ReserveStatus: String {
case ReserveNotMet = "reserve_not_met"
case NoReserve = "no_reserve"
case ReserveMet = "reserve_met"
var reserveNotMet: Bool {
return self == .ReserveNotMet
}
static func initOrDefault (rawValue: String?) -> ReserveStatus {
return ReserveStatus(rawValue: rawValue ?? "") ?? .NoReserve
}
}
we want to assume that gravity could return no_reserve or reserve_unknown as a SaleArtwork.reserve_status (and both should be treated the same way we treat NoReserve today.

@ashfurrow ashfurrow self-assigned this Sep 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants