Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-remove things from TYPE_CHECKING blocks #849

Open
asottile opened this issue Jul 1, 2023 · 2 comments
Open

auto-remove things from TYPE_CHECKING blocks #849

asottile opened this issue Jul 1, 2023 · 2 comments

Comments

@asottile
Copy link
Owner

asottile commented Jul 1, 2023

for instance in --py38-plus:

-if TYPE_CHECKING:
-    from typing import Protocol
-else:
-    Protocol = object
+from typing import Protocol

that's the most complex mode -- some of them are simpler (just imports)

@Mahdi-Hosseinali
Copy link

This is a bad idea. If you use | between types then it should be None | 'Protocol' which means Protocol is not used. Then the other linters start complaining about unused imports.

@asottile
Copy link
Owner Author

what are you even talking about

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants