Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entity-name: type of modifier value #310

Open
yarastqt opened this issue Apr 24, 2018 · 3 comments
Open

entity-name: type of modifier value #310

yarastqt opened this issue Apr 24, 2018 · 3 comments

Comments

@yarastqt
Copy link
Member

ModifierValue must be string or boolean

@Yeti-or Yeti-or changed the title EntityName Apr 24, 2018
@Yeti-or
Copy link
Member

Yeti-or commented Apr 24, 2018

right now modifier could be a string or true
let's make it string or boolean
https://github.com/bem/bem-sdk/blob/master/packages/entity-name/types/globals.d.ts#L10

@qfox
Copy link
Member

qfox commented Apr 24, 2018

Let's don't because it's entity-name and can't contain false val for modifier because of that.
What you talking about is value of modifier inside bemjson-node.mods container. Bet we need BemjsonNodeMods interface.

@qfox
Copy link
Member

qfox commented Apr 24, 2018

As a quick hack you can pull request a patch with interface declaration based on current type. Feel free to implement it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants