Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-kit] Improve code/runJavascript schema #2296

Closed
aomarks opened this issue Jun 25, 2024 · 0 comments · Fixed by #2410
Closed

[core-kit] Improve code/runJavascript schema #2296

aomarks opened this issue Jun 25, 2024 · 0 comments · Fixed by #2410
Assignees

Comments

@aomarks
Copy link
Member

aomarks commented Jun 25, 2024

  1. Add a port to runJavascript for configuring the input schema (there is already one called schema but it only sets the output schema -- we want input and output -- so I think we rename schema to outputSchema and add a new inputSchema port).

  2. Return the configured schema from the describe function (again, we do this for output already, but not yet input).

  3. Update the code utility function to pass those schemas (which we already collect as parameters to code) into the inputSchema and outputSchema port configurations of the runJavascript node it creates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant