Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1906 migrating old boards to build api syntax #2329

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

1906 migrating old boards to build api syntax #2329

wants to merge 6 commits into from

Conversation

Mearman
Copy link
Collaborator

@Mearman Mearman commented Jun 27, 2024

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6e0442a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR
@Mearman Mearman requested a review from dglazkov June 27, 2024 10:11
@Mearman Mearman marked this pull request as ready for review June 27, 2024 10:12
@TinaNikou
Copy link
Contributor

TinaNikou commented Jun 27, 2024 •
edited
Loading

On the 'Text Generator' board, the streaming option has been removed temporarily due to the type errors when trying to pass in the useStreaming input to invoke, so if you're happy for this to be merged in without it for now then we can create a separate issue to get this option built in again later once the problem with the types are resolved.
@dglazkov dglazkov requested review from aomarks and removed request for dglazkov June 27, 2024 18:13
@dglazkov
Copy link
Collaborator

Overall idea LGTM.

@aomarks could you take a look at the conversion details?
aomarks
aomarks requested changes Jun 27, 2024
View reviewed changes
Copy link
Member

@aomarks aomarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good! A few comments that are all fairly minor.
packages/breadboard-web/src/boards/simplest.ts Outdated Show resolved Hide resolved
packages/breadboard-web/src/boards/simplest.ts Outdated Show resolved Hide resolved
packages/breadboard-web/src/boards/simplest.ts Outdated Show resolved Hide resolved
packages/breadboard-web/src/boards/text-generator.ts Outdated Show resolved Hide resolved
packages/breadboard-web/src/boards/text-generator.ts Outdated Show resolved Hide resolved
packages/breadboard-web/src/boards/open-alex-entity-search-list.ts Outdated Show resolved Hide resolved
packages/breadboard-web/src/boards/open-alex-entity-search-list.ts Outdated Show resolved Hide resolved
packages/breadboard-web/src/boards/open-alex-entity-search-list.ts Outdated Show resolved Hide resolved
packages/breadboard-web/src/boards/open-alex-entity-search-list.ts Outdated Show resolved Hide resolved
packages/breadboard-web/src/boards/open-alex-entity-search-list.ts Outdated Show resolved Hide resolved
@TinaNikou
Copy link
Contributor

Apologies, I shall fix the commit on this tomorrow!
@TinaNikou TinaNikou force-pushed the 1906-migrating-old-boards-to-build-api-syntax branch from ea1fcd0 to fdfd9ba Compare July 12, 2024 09:03
@Mearman Mearman requested review from aomarks and TinaNikou and removed request for TinaNikou July 12, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@Mearman @TinaNikou @dglazkov @aomarks