-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1906 migrating old boards to build api syntax #2329
base: main
Are you sure you want to change the base?
1906 migrating old boards to build api syntax #2329
Conversation
|
On the 'Text Generator' board, the streaming option has been removed temporarily due to the type errors when trying to pass in the |
Overall idea LGTM. @aomarks could you take a look at the conversion details? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good! A few comments that are all fairly minor.
packages/breadboard-web/src/boards/open-alex-entity-search-list.ts
Outdated
Show resolved
Hide resolved
packages/breadboard-web/src/boards/open-alex-entity-search-list.ts
Outdated
Show resolved
Hide resolved
packages/breadboard-web/src/boards/open-alex-entity-search-list.ts
Outdated
Show resolved
Hide resolved
packages/breadboard-web/src/boards/open-alex-entity-search-list.ts
Outdated
Show resolved
Hide resolved
packages/breadboard-web/src/boards/open-alex-entity-search-list.ts
Outdated
Show resolved
Hide resolved
Apologies, I shall fix the commit on this tomorrow! |
ea1fcd0
to
fdfd9ba
Compare
./packages/breadboard-web/src/boards/simplest.ts
to build api #2327./packages/breadboard-web/src/boards/open-alex-entity-search-list.ts
to build API #2326./packages/breadboard-web/src/boards/text-generator.ts
to build api #2325