Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2340 convert ./packages/agent-kit/src/boards/specialist.ts #2342

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Copy link

changeset-bot bot commented Jun 27, 2024

⚠️ No Changeset found

Latest commit: 66860f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@dglazkov dglazkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent LGTM! @aomarks could you take a look at the conversation details?

@dglazkov dglazkov requested a review from aomarks June 27, 2024 18:15
const context = input({
title: "Context in",
description: "Incoming conversation context",
type: annotate(array("string"), {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be an array of objects, rather than an array of strings?

type: annotate(array("string"), {
behavior: ["llm-content"],
}),
examples: [[JSON.stringify(sampleContext, null, 2)]]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't ever need the JSON serialize examples with the build API. It expects the actual value type.

Also here and below, there seem to be two layers of arrays? Like this should be an array of strings, but it's actually an array of arrays of strings.


const specialist = await board(({ in: context, persona, task, tools }) => {
const specialist = await oldBoard(({ in: context, persona, task, tools }) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't be possible to mix the old and new APIs within a single board. But I assume this is just a partial conversion for the draft PR yeah?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants