-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2340 convert ./packages/agent-kit/src/boards/specialist.ts
#2342
base: main
Are you sure you want to change the base?
2340 convert ./packages/agent-kit/src/boards/specialist.ts
#2342
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The intent LGTM! @aomarks could you take a look at the conversation details?
const context = input({ | ||
title: "Context in", | ||
description: "Incoming conversation context", | ||
type: annotate(array("string"), { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be an array of objects, rather than an array of strings?
type: annotate(array("string"), { | ||
behavior: ["llm-content"], | ||
}), | ||
examples: [[JSON.stringify(sampleContext, null, 2)]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't ever need the JSON serialize examples with the build API. It expects the actual value type.
Also here and below, there seem to be two layers of arrays? Like this should be an array of strings, but it's actually an array of arrays of strings.
|
||
const specialist = await board(({ in: context, persona, task, tools }) => { | ||
const specialist = await oldBoard(({ in: context, persona, task, tools }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shouldn't be possible to mix the old and new APIs within a single board. But I assume this is just a partial conversion for the draft PR yeah?
./packages/agent-kit/src/boards/specialist.ts
#2340