Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual editor property renames only update the node schema and not wired edge ports when renamed in the visual editor #2418

Open
Mearman opened this issue Jul 4, 2024 · 1 comment

Comments

@Mearman
Copy link
Collaborator

Mearman commented Jul 4, 2024

This might not be immediately easy to fix. But now that the property renaming has been fixed in the visual editor (thanks, @paullewis), would it be possible to update the ports the edges are wired to when a property name is updated?

e.g.

  • input.foo -> output.bar
  • rename foo to baz
  • The schema is updated
  • The input node will still have the input.foo -> output.bar edge connecting a no longer fulfilled property.

Ideally, when a property is renamed and is already connected to edges, it would be nice for any associated edges to have the ports they're connected to updated.

This may be suitable for a toggleable "sync port renames" setting, as I can imagine people wanting both behaviours.

@paullewis
Copy link
Contributor

I really like the setting suggestion, because on the surface this is a duplicate of #930. I'll have a ponder, but yeah my hunch is that we'd need to update the port names to match as part of a multi-edit, and that seems doable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants