[breadboard-web] Investigate deletion of entries on the Secrets section of the Settings page

[alexandraM98]

In the visual editor, in the Settings modal under the Secrets section, there is something I noticed with the behaviour when deleting an entry which I found a bit counterintuitive.

For example, if I have an existing entry and I click the "trash" icon to delete it, I get asked to confirm the action and then the list is empty with the message "There are currently no entries". This seemed to indicate that the entries were indeed removed. However, it looks like the changes won't apply unless I also click Save before closing the modal, because when I reloaded the page and went back to settings the entry I had "deleted" was still there.

An idea could be to temporarily add deleted entries to a list to indicate that they are "pending deletion" and then when the users click on "Save" at the bottom, they could then get a message from the browser asking if they are sure they want to delete the entries on the "pending" list.

Below is a screenshot of a quick mockup to help with visualising the suggestion above:

[paullewis]

You're absolutely right, it's counterintuitive. Another approach would be to eagerly emit the change since we already ask you if you're sure you want to do it. So I think we should pick one: either don't ask and have a "pending you hitting save" button or we do it eagerly. I think I prefer the former as you might think "bah, I accidentally deleted the wrong secret" and you still have a chance to back out of the change.

What do you think?

[Mearman]

A suggestion for the best UX for the pending mode.

• Only enable and colour the save button when there are actual changes to be saved.
• For "super users" have a "delete without prompt" e.g. Shift + Backspace
  • The "Save" still needs to be pressed after.

[alexandraM98]

Personally, I would prefer to have a way of backing out of deleting secrets too. I agree with using the former approach that you mentioned @paullewis.
I could start looking into implementing this feature following a similar approach to what I presented in the screenshots above if that's okay. But, additionally, it might also be useful to have some "undo" icon next to each entry pending deletion so that people can add/remove entries from that list without having to hit Cancel and then reopen the Settings modal.

I also agree with the UX suggestion from @Mearman. I think disabling the Save button until there's an actual change to "commit" is a good idea.