Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set options = {} to prevent errors #191

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Set options = {} to prevent errors #191

wants to merge 1 commit into from

Conversation

toshi-k
Copy link

@toshi-k toshi-k commented May 30, 2024

This PR resolve #190 issue.

When we utilize motmetrics with other packages such as nuscenes-devkit, options = {"ana": ana} sometimes cause errors.
This PR set options = {} when ana is None and prevent errors.
@toshi-k
Copy link
Author

toshi-k commented Jun 6, 2024

@cheind Could you review this PR ?
@cheind
Copy link
Owner

cheind commented Jun 10, 2024

Tests are passing - just wondering where the ana came from in the first place. Will investigate, so that we don't accidentally break things
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@toshi-k @cheind