Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advertisingSid property to ScanResult and RxBleInternalScanResult #854

Open
KrzysztofMamak opened this issue May 23, 2024 · 3 comments

Comments

@KrzysztofMamak
Copy link

Is your feature request related to a problem? Please describe.
com.polidea.rxandroidble2.scan.ScanResult does not contain an information about advertising sid which is needed for supporting Bluetooth Auracast feature (https://www.bluetooth.com/wp-content/uploads/Files/Specification/HTML/24670-BASS-html5/out/en/index-en.html#UUID-2a17a3a2-36f9-8cb4-0877-3b56055a7955). It means that there is no option to retrieve this information from the rxandroidble library.

Describe the solution you'd like
com.polidea.rxandroidble2.scan.ScanResult and com.polidea.rxandroidble2.internal.scan.RxBleInternalScanResult classes can be extended with advertisingSid property. This value can be retrieved using android.bluetooth.le.ScanResult.getAdvertisingSid method (https://developer.android.com/reference/kotlin/android/bluetooth/le/ScanResult#getadvertisingsid) and propagated in com.polidea.rxandroidble2.internal.scan.InternalScanResultCreator.

I can volunteer and submit a PR soon.

@dariuszseweryn
Copy link
Owner

Hey, sorry for a long pause, got a busy time at work. Feel free to open a PR 👍

@KrzysztofMamak
Copy link
Author

I'll open a PR soon.

@dariuszseweryn
Copy link
Owner

I have one request, when adding tests please use JUnit – I've started migrating to it from Spock as it's not supported for Android anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants