-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error compiling on Fedora 40 #65
Comments
The error is in |
I see that simdjson is already packaged for a lot of distributions: Would it be feasible to use the library version instead of bundling it? |
I would rather keep it as is and fix the cause properly than add an option to link to the system library (which would only be used by you). It would only increase the complexity of the build system. |
I cannot reproduce the issue. Reposted from simdjson/simdjson#2217
quickstart.cpp: #include <iostream>
#include "simdjson.h"
using namespace simdjson;
int main(void) {
ondemand::parser parser;
padded_string json = padded_string::load("twitter.json");
ondemand::document tweets = parser.iterate(json);
std::cout << uint64_t(tweets["search_metadata"]["count"]) << " results." << std::endl;
} Note that simdjson is part of systems such as Node.js which are widely distributed over many, many systems. |
The report should not affect versions after PR #64 |
Thanks for trying to reproduce it! I think I was using some newer version of simdjson from master, not sure which one. Now it's updated to the latest release 3.9.5 if it makes any difference. But I don't know what could be wrong then. |
@deathkiller The version you had is fine. The updated version is also fine. I recommend you close this issue. The problem is that @musuruan is not using your current code. You have nothing to fix. You either need a new release, or @musuruan needs to use GCC 13 or @musuruan can patch your release. GCC 14 introduced some breaking changes and it broke the build of a few libraries, which in turn broke a few other systems. That was fine because no stable Linux distributed immediately adopted GCC 14 (which was first publicly released in May 2024). As far as simdjson is concerned, we fixed the issue in March (Version 3.9.1) prior to the first public release of GCC 14 (which was 14.1.) Fedora is the bleeding-edge/experimental distribution, upstream of stable distributions like RedHat, and it went with GCC 14. Which is fine. |
I am using the latest jazz2 tagged release, which is 2.7.0. gcc 13 is no longer available in F40. @deathkiller can you please tag a new release which fix this issue? |
Unfortunately I can't. There is work in progress that I can't release as a new version right now, it would cause confusion. Why you can't just download the latest master branch? |
I was making an RPM package. Usually you package a stable version. I'll just wait for the next release. |
@musuruan Somewhat related... Fedora 40 has simdjson 3.7 as a package. It should not be able to build with GCC 14. Maybe this needs to be updated? |
Jazz² Resurrection version
2.7.0
System information
Fedora 40
Issue description
When compiling on F40 with Fedora optflags I get the following error:
optflags are:
It is probably gcc14 related.
Steps to reproduce
I am compiling the SDL version.
Build log:
build.log
The text was updated successfully, but these errors were encountered: