Can't cache documents?

[reggi]

Currently you can't cache a document because you can't change the status response using Etag / If-None-Match, curious if there's a reason this was only done for static content and not pages?

export const handler: Handlers = {
  async GET(req, ctx) {
    const resp = await ctx.render();
    
    const x = req.headers.get('If-None-Match')
    if (x === 'W/deadbeef') {
      return resp // need to send 304
    }
    
    resp.headers.set("ETag", "deadbeef");
    return resp;
  },
};

[lucacasonato]

I don't quite understand - why can you not set the Etag header on the response object? That should work.

[reggi]

From what I read I needed to also return a http status code of 304 after I confirm that the If-None-Match matches.

Regardless of this specific application I think it's odd we're not able to change the status code of a route arbitrarily, even with the new implementation of 404 it's still abstracted out.

[lucacasonato]

Then you should replace the line return resp // need to send 304 with return new Response("", { status: 304 });.

Also you should do this before rendering, otherwise there is not going to be much benefit.

[reggi]

I believe the correct way to do this is:

export const handler: Handlers = {
  async GET(req, ctx) {    
    const x = req.headers.get('If-None-Match')
    // replace this with a unique string for each page to establish a cache criteria
    const id = 'deadbeef'
    if (x === `W/${id}`) {
       return new Response("", { status: 304 });
    }
    resp.headers.set("ETag", id);
    return await ctx.render();
  },
};