Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: double the word on Plugins section #2518

Closed
Iuriiiii opened this issue Jun 16, 2024 · 3 comments · Fixed by #2522
Closed

docs: double the word on Plugins section #2518

Iuriiiii opened this issue Jun 16, 2024 · 3 comments · Fixed by #2522

Comments

@Iuriiiii
Copy link
Contributor

Hi, A little grammar error there:

image

It can be fixed easily just removing the duplicated the word in the file docs/latest/concepts/plugin.md:83:29

@Iuriiiii
Copy link
Contributor Author

Just in case, i tried to open a pr, but i couldn't due a git error (permission denied)

@marvinhagemeister
Copy link
Collaborator

@Iuriiiii The way Pull Requests work in GitHub or elsewhere is that you fork the repository, push your changes to a branch in your fork and the create a pull request from your fork that targets the original repository. The permission error you're seeing means that you tried to push the branch into this repository instead of your fork. Create a fork first.

@Iuriiiii
Copy link
Contributor Author

Iuriiiii commented Jun 17, 2024

@Iuriiiii The way Pull Requests work in GitHub or elsewhere is that you fork the repository, push your changes to a branch in your fork and the create a pull request from your fork that targets the original repository. The permission error you're seeing means that you tried to push the branch into this repository instead of your fork. Create a fork first.

JAJAJAJAJA You're right!! So sorry, incredible that you have to explain me something so basic, long time ago since I done a PR to a open source project, my bad 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants