Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno Fresh is unusable in production with Signal #2564

Closed
saeho opened this issue Jun 30, 2024 · 1 comment
Closed

Deno Fresh is unusable in production with Signal #2564

saeho opened this issue Jun 30, 2024 · 1 comment

Comments

@saeho
Copy link

saeho commented Jun 30, 2024

Screen.Recording.2024-06-30.at.4.32.46.PM.mov

Repo: https://github.com/saeho/fresh-signal-bug

Deno Fresh cannot be used in production unless the app completely doesn't use Signals or unless this bug is fixed.

In this reproduceable demo (video + repo), you will see the minimal codebase working when I build & run main.ts to serve the app at port 8000. Then if I re-build and re-serve the app main.ts at port 8000, there is no crash or service interruptions, it just works, and existing users who are on the app before the re-deploy are uninterrupted.

However, the moment I add a single line of code "useSignal()" into a single component, and then re-deploy main.ts at port 8000, every single person who was on that app before the newer version of the app cannot use the app any more.

Unless this issue can be resolved somehow, there's no way I or anyone can use Deno Fresh in production. We need to build and ship new features every day, and if we're going to break every user's experience every single time we upload a new version, that's... that's just not okay.

I truly believe this is a high alert issue for Fresh development.

NOTE: PM2 was not used to deploy Fresh app.

@marvinhagemeister
Copy link
Collaborator

This looks like the same reproduction as in #2562 and that it was narrowed down to not be pm2 related. Let's keep the discussion there. I'd rather spend time investigating issues rather than spending having to jump between multiple issues for the same thing and answering in multiple threads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants