Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document padding #130

Open
slxcc opened this issue Jun 17, 2014 · 4 comments
Open

Document padding #130

slxcc opened this issue Jun 17, 2014 · 4 comments

Comments

@slxcc
Copy link

slxcc commented Jun 17, 2014

Reading the source of cipherModes.js and doing a few tests, AES-ECB and AES-CBC seems to use PKCS7 as default padding.
In my opinion, it would be a welcome addition to the documentation since any encrypt or decrypt operation from a third party using another implementation may require those parameters to build the appropriate cipher instance.
@dlongley
Copy link
Member

Yes, you're right, this should be added to the documentation.
@jacek213
Copy link
Contributor

Please add this information to documentation, then it would be clear without going through the source code.
@jacek213
Copy link
Contributor

I've made a PR for this: #461
@edgepirate
Copy link

@jacek213 @dlongley is it possible to use other padding schemes (ex: pkcs5 for AES-ECB)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants
@dlongley @jacek213 @slxcc @edgepirate