Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async validation #101

Open
scotthovestadt opened this issue Feb 13, 2016 · 2 comments
Open

Async validation #101

scotthovestadt opened this issue Feb 13, 2016 · 2 comments
Assignees

Comments

@scotthovestadt
Copy link
Contributor

Validation shouldn't need to throw an error. It doesn't fit with the way the rest of the code works. It should be allowed to return a promise or act on a callback like everything else does.

I need async validation.

@dthree Any concerns?

@dthree
Copy link
Owner

dthree commented Feb 13, 2016

I recently updated it (like 2 days ago) so you can just return true, or false, or a message.

https://github.com/dthree/vorpal/wiki/api-|-vorpal.command#commandvalidatefunction

I agree with async as an option, sorry, I just hadn't gotten to it. 👍 on implementing.

@JeffSpies
Copy link

What's the status of this one? Still interested? I'd also like async validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants