Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Are tests not written correctly? #150

Open
eliperelman opened this issue May 24, 2016 · 1 comment
Open

Are tests not written correctly? #150

eliperelman opened this issue May 24, 2016 · 1 comment

Comments

@eliperelman
Copy link
Contributor

eliperelman commented May 24, 2016 •
edited
Loading

In trying to update the solution for #52, I ran across my updates not passing the tests. First up, the test says that its missing the required option --required. I'm not sure if I actually broke something, or if the test just wasn't written properly. It appears that while the fixture doesn't pass any options, the command actually wants the --required option, it just wasn't provided.

Thoughts? Is this test written correctly?
@dthree
Copy link
Owner

dthree commented May 25, 2016

It might be. Correct the test to what you think it should do, and post the test code here, and I'll make sure it confirms to how I expected it to behave. Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@eliperelman @dthree