Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] linkTag injection type #319

Open
benmccann opened this issue Sep 6, 2020 · 2 comments
Open

[feature] linkTag injection type #319

benmccann opened this issue Sep 6, 2020 · 2 comments

Comments

@benmccann
Copy link
Contributor

Webpack's style-loader has several different injectTypes. It would be nice if some of these options were supported here as well. My motivation for asking is that I'm wondering if the number of style tags created by the plugin today would result in optimal performance. It seems like we could recalculate the CSSOM fewer times by injecting only a single style tag per chunk. And injecting the styles via a link tag might result in reduced data transfer for hydrated apps, which would be quite nice

I think that the extract option in this plugin creates only a single CSS file? It would be nice if there were a way to create one css chunk per js chunk in order to support this feature. Then I might be able to provide a function to inject in order to write the link tag myself.
@benmccann benmccann mentioned this issue Sep 8, 2020
Open
@benmccann
Copy link
Contributor Author

I've got a version of this working here: https://github.com/sveltejs/sapper/blob/a05ba1b7dd13b0216165bc5e9767bf6e6870e153/src/core/create_compilers/RollupCompiler.ts#L129

Feel free to steal it!
@o-mega
Copy link

o-mega commented Dec 4, 2020

+1 to add this feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@benmccann @o-mega