Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement preserve module extract #417

Closed
wants to merge 1 commit into from
Closed

feat: implement preserve module extract #417

wants to merge 1 commit into from

Conversation

sweetliquid
Copy link

@sweetliquid sweetliquid commented Mar 30, 2022 •
edited
Loading

Fixes #336
@GimpMaster
Copy link

@sweetliquid - This looks awesome. I also didn't like the style-inject method. I would love to see this get merged in and a new package build.

I don't really want to have to build this myself. Have you built and pushed this to npmjs by chance?
@N0NamedGuy
Copy link

N0NamedGuy commented May 25, 2022 •
edited
Loading

Will this merge be approved? The circleci test failed due to node-gyp and node-sass shenanigans...
@sweetliquid
Copy link
Author

I'd like to get some advice from the maintainers before deciding on the next steps, such as updating the unit tests.
@sweetliquid sweetliquid deleted the preserve-modules-extract branch September 16, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@sweetliquid @GimpMaster @N0NamedGuy