-
-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docs for cloud-based EV code signing #3617
Comments
Here's mine that works for SSL.com; const forgeConfig: ForgeConfig = {
packagerConfig: {
// invalid according to typescript,
// but this is the only place it works,
// all the other places you can put this key will *not* pick it up
// during the build process and use the built-in signTool
// @ts-ignore
signToolPath: path.resolve(
"C:\\Users\\circleci\\project\\CodeSignTool.bat",
),
signWithParams: [
`-override="true"`,
`-credential_id="${process.env.WINDOWS_CERT_CREDENTIAL_ID}"`,
`-username="${process.env.WINDOWS_CERT_USER_NAME}"`,
`-password="${process.env.WINDOWS_CERT_PASSWORD}"`,
`-totp_secret="${process.env.WINDOWS_CERT_USER_TOTP}"`,
],
},
};
export default forgeConfig; |
I've been trying to use the |
as my last code snippet said, even though typescript reports it as invalid, i found this the only place to put the signing config that actually picks up the options; packagerConfig give that a try? |
I am also running into a similar situation using an SSL EV certificate and the @electron-forge/maker-squirrel. |
Pre-flight checklist
Problem description
The docs haven't been updated for a year now regarding windows code signing, electron's own docs have however and make reference to
windowsSign
in forge, but I would love to have examples of how to usewindowsSign
on forge in combination withMakerSquirrel
, as I seem unable to get it working with ssl.com's cloud signing after several months of stumbling in and out of trying 🤡Proposed solution
Update the docs with examples for;
Alternatives considered
I tried Electron Forge SSL Code Sign Plugin but it runs too late and doesn't update the RELEASES file, meaning no updates are installed on Windows due to a checksum mismatch.
Additional information
No response
The text was updated successfully, but these errors were encountered: