Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Electron Forge too opinionated? #3638

Open
3 tasks done
mmarczell-graphisoft opened this issue Jun 20, 2024 · 0 comments
Open
3 tasks done

Is Electron Forge too opinionated? #3638

mmarczell-graphisoft opened this issue Jun 20, 2024 · 0 comments
Labels

Comments

@mmarczell-graphisoft
Copy link

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Problem description

Electron Forge, by default, pulls in some things that not everybody needs. The two that I've just found:

  • The import script always initializes a git repository if it doesn't find one. This is an annoyance for developers who are using some other version control software.
  • Both the import script and the quick start templates always pull in electron-squirrel-startup as a dependency. This is an annoyance for someone wishing to use other means of distribution such as the Microsoft Store where no such installer tool is needed.

Proposed solution

The Electron Forge import script and templates should not pull in stuff that some developers will then have to remove.

Alternatives considered

These could also be optional arguments to the import script for example.

Additional information

It is also worth considering the situation of someone that's quite new to Electron development. Searching for the 'best practices' will probably lead them to Electron Forge and its templates, which then proceed to pull in a whole host of technologies, for which the motivation or rationale is not really explained anywhere. It's just "This is how everybody does it and don't ask questions". I think this creates a frustrating developer experience and an unhealthy culture of "shut up and follow the pack".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 participants