Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing "copyright" config to DEB and RPM makers #3643

Open
3 tasks done
p2kmgcl opened this issue Jun 26, 2024 · 0 comments
Open
3 tasks done

Allow passing "copyright" config to DEB and RPM makers #3643

p2kmgcl opened this issue Jun 26, 2024 · 0 comments

Comments

@p2kmgcl
Copy link

p2kmgcl commented Jun 26, 2024

Pre-flight checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project uses.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Problem description

It looks like electron forge is not passing "copyright" options to DEB and RPM makes, the result is that any application will have the "Electron Github" copyright in the documentation of the package (grep '^' /usr/share/doc/my-electron-app/copyright).

Proposed solution

Both redhat and debian installers already support this parameter, we only need to pass that information to them:

Alternatives considered

We've considered patching the deb/rpm packages after building them, but I would like to avoid manipulating the binaries generated by electron forge.

Additional information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants