Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace presigned S3 URL with lambda request #10456

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Replace presigned S3 URL with lambda request #10456

merged 3 commits into from
Jul 9, 2024

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Jul 5, 2024 •
edited
Loading

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
@radeusgd radeusgd self-assigned this Jul 5, 2024
@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label Jul 5, 2024
@radeusgd radeusgd changed the title [Do not merge yet] Replace presigned S3 URL with lambda request Jul 8, 2024
@radeusgd radeusgd marked this pull request as ready for review July 8, 2024 15:19
@radeusgd
Copy link
Member Author

radeusgd commented Jul 8, 2024

All Cloud tests that I remembered of are passing on my local run.
@radeusgd
Copy link
Member Author

radeusgd commented Jul 8, 2024

I remembered one more test - in Image_Tests: should be able to write image data to a data link and read it back is failing... Investigating.
@jdunkerley jdunkerley added the CI: Ready to merge This PR is eligible for automatic merge label Jul 9, 2024
@mergify mergify bot merged commit a3dc50f into develop Jul 9, 2024
37 checks passed
@mergify mergify bot deleted the wip/radeusgd/update-cloud-file-get branch July 9, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
4 participants
@radeusgd @AdRiley @jdunkerley @GregoryTravis