Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login_url lacks a mode hint #602

Open
panva opened this issue May 24, 2024 · 2 comments
Open

login_url lacks a mode hint #602

panva opened this issue May 24, 2024 · 2 comments

Comments

@panva
Copy link

panva commented May 24, 2024

There's only one login_url in the IdP configuration and it's shared for all modes.

But the modes can be configured differently in the IdP configuration, e.g.

{
  // ...
  "modes": {
    "button": {
      "supports_use_other_account": true,
    },
    "widget": {
      "supports_use_other_account": false,
    }
  }
}

Should there be an indication about the used mode at the login_url when it's invoked?

@npm1
Copy link
Collaborator

npm1 commented May 24, 2024

Hmm why though? User signing in to the IdP should not depend on the FedCM mode that the RP is requesting, should it?

@panva
Copy link
Author

panva commented May 24, 2024

Hmm why though? User signing in to the IdP should not depend on the FedCM mode that the RP is requesting, should it?

For one it may be valuable to know the conversion of one over the other. Altho we do get the mode in the subsequent assertion call we can't tell the drop off in between the modes during login.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants