Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is IdentityCredentialRequestOptionsContext for FedCM UI only? #603

Open
panva opened this issue May 24, 2024 · 5 comments
Open

is IdentityCredentialRequestOptionsContext for FedCM UI only? #603

panva opened this issue May 24, 2024 · 5 comments

Comments

@panva
Copy link

panva commented May 24, 2024

This context, which the RP can select one of from a predefined list, controls the wording in the browser UI.

It would be helpful to get this RP-selected context in the login_url as well as at the assertion endpoint to discern between the language used on the login page as well as in the possible Continuation API triggered popup that renders IdP-provided UI.

@npm1
Copy link
Collaborator

npm1 commented May 24, 2024

It is for FedCM UI only, yea. It seems plausible to have it in some of those, if you have specific use cases in mind?

@panva
Copy link
Author

panva commented May 24, 2024

It is for FedCM UI only, yea. It seems plausible to have it in some of those, if you have specific use cases in mind?

Knowing our customers they'll want to have the copies aligned. Having the same hint that was given to fedcm is a straight forward way of aiding that.

@npm1
Copy link
Collaborator

npm1 commented May 24, 2024

Copies of what? I'm not following.

@panva
Copy link
Author

panva commented May 24, 2024

Copies of what? I'm not following.

Apologies, I meant the used language/text

@samuelgoto
Copy link
Collaborator

Yeah, this seems like a somewhat trivial and harmless (in theory, it increases a bit of entropy in the login_url, but I think it is plausible) change to make.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants