Improve Neovim 0.5 support

[gegoune]

Amazing colorscheme, can't find a better one currently! Great job. Only things I am missing which result in inconsistent highlighting are built in LSP support and TreeSitter support on Neovim.

Is there a chance those could be added? Thanks!

[fenetikm]

I was just thinking about LSP and treesitter - I'll get on it.

[fenetikm]

@cloggier so I have started on this - could you please give me a bit of direction by letting me know:

• which plugins (and config? dotfiles?) do you have installed for lsp and treesitter
• which languages in particular are you using with lsp and treesitter

I have only this morning installed a bunch of stuff and I can see there is quite a bit to do. Some kind of sane starting point would be munch appreciated as opposed to boiling the ocean.

[gegoune]

Awesome, very happy to help!

• which plugins (and config? dotfiles?) do you have installed for lsp and treesitter

• treesitter
  • nvim-treesitter/nvim-treesitter-refactor
  • nvim-treesitter/nvim-treesitter-textobjects
  • romgrk/nvim-treesitter-context
• LSP
  • kosayoda/nvim-lightbulb
  • nvim-lua/lsp-status.nvim
  • ojroques/nvim-lspfuzzy
  • ray-x/lsp_signature.nvim

• which languages in particular are you using with lsp and treesitter

• bash
• css
• html
• javascript
• json
• lua
• python
• regex
• vue
• yaml

But shouldn't treesitter be sort of language independent when it comes to highlighting? Like, Variable wouldn't be the same for python and js?

I have only this morning installed a bunch of stuff and I can see there is quite a bit to do. Some kind of sane starting point would be munch appreciated as opposed to boiling the ocean.

Although you have asked about plugins (which would be very nice to have supported if they have any highlight groups at all) I was more thinking along lines of :h lsp-highlight, like lsp errors, etc.

Extra:
Perhaps some latest plugins that surfaced recently, like kyazdani42/nvim-tree.lua, but that's probably beyond scope of that issue.

[fenetikm]

Great - that will get me going.

My understanding is that treesitter "should" be language independent but I imagine it will depend on the language parser and the querying. We can only hope!

Probably take me a week to have a look at this. Obviously PRs welcome :)

[gegoune]

@fenetikm do you mind me asking nvim-treesitter devs to add falcon to colorschemes list on their wiki?

[fenetikm]

that would be great @cloggier, thanks 👍

[gegoune]

Turned one one can just edit wiki, done: https://github.com/nvim-treesitter/nvim-treesitter/wiki/Colorschemes#fenetikmfalcon

Thanks for great colorscheme! :)

[gegoune]

Would you mind adding groups for nvim-treesitter-refactor? There are only three.

I tried adding them myself, but could not find anything standing out enough without being too much in the face. Tried combination of bold, italic, underline, none really visible enough. standout might be too much.

[fenetikm]

I'll take a look 👀