Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(database): fix stream order when a transaction is running #10182

Closed
wants to merge 1 commit into from
Closed

fix(database): fix stream order when a transaction is running #10182

wants to merge 1 commit into from

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Dec 26, 2022

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

Similar fix to #10181
closes #10145

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.
@Lyokone Lyokone marked this pull request as draft December 27, 2022 07:36
@Lyokone Lyokone closed this Dec 29, 2022
@Lyokone Lyokone reopened this Dec 29, 2022
@JoolsMcFly
Copy link

Hi @Lyokone, thanks for looking into this.

Bonny tried your fix but it does not solve our issue #10145 unfortunately.
To reproduce:

  1. init a Realtime database with the JSON structure shown in my message.
  2. call once on data and you get ["a","b","c","d","e","f","g","h"] as expected.
  3. call get on data and you get ["a","b","c","d","e","f","g","h"] as expected.
  4. subscribe to top level organizations node
  5. call once on data and you get ["a","b","c","d","e","f","g","h"] as expected.
  6. call get on data and you get the whole organizations node, not as expected. ^^

If you could have another go at it it would help a lot. Thanks!
@JoolsMcFly JoolsMcFly mentioned this pull request Jan 31, 2023
Open
@Lyokone Lyokone closed this Oct 4, 2023
@firebase firebase locked and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants
@Lyokone @JoolsMcFly