docs(core, web): update the instructions on how to manually import Firebase SDKS now that we are using the modular Web SDKs #11892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rebase SDKS now that we are using the modular Web SDKs
|
@kevinthecheung Hi, this a doc change so i'm pinging you |
exaby73
approved these changes
Nov 15, 2023
russellwheatley
approved these changes
Nov 15, 2023
kevinthecheung
requested changes
Nov 15, 2023
| @@ -265,20 +265,20 @@ By default, the Firebase Flutter SDK auto-injects the Firebase JavaScript SDK wh | |||
|
|
|||
| 2. Load the script manually using one of the following alternatives: | |||
|
|
|||
| - Add the SDK explicitly to your `web/index.html` file: | |||
| - Add the SDK explicitly to your `web/index.html` file, inside the `window.addEventListener` callback: | |||
There was a problem hiding this comment.
what event? load? can you include the addEventListener call in the examples?
There was a problem hiding this comment.
I've added more context, let me know if it looks okay for you
Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>
kevinthecheung
approved these changes
Nov 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #11744
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?