You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Make RadioGroup and CheckboxGroup layout patterns the same.
The final cell rendering for GroupedRadio and GroupedCheckbox are different with slightly different separator behavior for no reason. They should be synced up.
The radio is a Column(child: Row(child: ...)) with a mainAxisSize and crossAxisAlignment set
The checkbox is Row(child: ...)
Symptoms
Someone added the feature to RadioGroup in PR #1106.
RadioGroup
Supports the separator if the orientation is vertical or horizontal. Has vertical and !vertical handlers to tune the position in either the Row or in the Column.
CheckboxGroup
Adds a separator in the row ignoring the group's orientation because there is no Column to put it in.
Alternatives you've considered
Submit pull requests to align the behavior
I can do the PR if someone picks an option.
Options
align on GroupedCheckbox.
Essentially back out PR 1106
align on GroupedRadio.
Apply the changes to GroupedCheckbox that were applied to GroupedRadio in PR 1106
Aditional information
GroupedCheckbox
returnRow(
mainAxisSize:MainAxisSize.min,
children:<Widget>[
if (controlAffinity ==ControlAffinity.leading) control,
Flexible(flex:1, child: label),
if (controlAffinity ==ControlAffinity.trailing) control,
if (separator !=null&& index != options.length -1) separator!,
],
);
GroupedRadio
returnColumn(
mainAxisSize:MainAxisSize.min,
crossAxisAlignment:CrossAxisAlignment.start,
children: [
Row(
mainAxisSize:MainAxisSize.min,
children: [
if (widget.controlAffinity ==ControlAffinity.leading) control,
Flexible(child: label),
if (widget.controlAffinity ==ControlAffinity.trailing) control,
if (widget.orientation !=OptionsOrientation.vertical &&
widget.separator !=null&&
index != widget.options.length -1)
widget.separator!,
],
),
if (widget.orientation ==OptionsOrientation.vertical &&
widget.separator !=null&&
index != widget.options.length -1)
widget.separator!,
],
);
The text was updated successfully, but these errors were encountered:
Is there an existing issue for this?
Package/Plugin version
9.1.0
What you'd like to happen
Make RadioGroup and CheckboxGroup layout patterns the same.
The final cell rendering for GroupedRadio and GroupedCheckbox are different with slightly different separator behavior for no reason. They should be synced up.
Column(child: Row(child: ...))
with a mainAxisSize and crossAxisAlignment setRow(child: ...)
Symptoms
Someone added the feature to
RadioGroup
in PR #1106.RadioGroup
Supports the separator if the orientation is vertical or horizontal. Has
vertical
and!vertical
handlers to tune the position in either theRow
or in theColumn
.CheckboxGroup
Adds a separator in the row ignoring the group's orientation because there is no
Column
to put it in.Alternatives you've considered
I can do the PR if someone picks an option.
Options
GroupedCheckbox
.GroupedRadio
.GroupedCheckbox
that were applied toGroupedRadio
in PR 1106Aditional information
GroupedCheckbox
GroupedRadio
The text was updated successfully, but these errors were encountered: