Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FormBuilderDatePicker]: keyboardType is not passed to material showDatePicker #1351

Closed
4 of 7 tasks
Brunobnahorny opened this issue Jan 18, 2024 · 1 comment · Fixed by #1352
Closed
4 of 7 tasks
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Brunobnahorny
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Package/Plugin version

7.7.0

Platforms

  • Android
  • iOS
  • Linux
  • MacOS
  • Web
  • Windows

Flutter doctor

Flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.16.5, on Microsoft Windows [versÆo 10.0.22621.3007], locale pt-BR)
[✓] Windows Version (Installed version of Windows is version 10 or higher)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0-rc4)
[✓] Chrome - develop for the web
[✓] Visual Studio - develop Windows apps (Visual Studio Community 2019 16.11.10)
[✓] Android Studio (version 2022.2)
[✓] VS Code (version unknown)
    ✗ Unable to determine VS Code version.
[✓] VS Code, 32-bit edition (version unknown)
    ✗ Unable to determine VS Code version.
[✓] VS Code, 64-bit edition (version 1.85.1)
[✓] Connected device (4 available)
[✓] Network resources

• No issues found!

Minimal code example

Code sample
      final widget = FormBuilderDateTimePicker(
        keyboardType: TextInputType.text,
        inputType: InputType.text,
      );

Current Behavior

The keyboardType parameter is not passed to material showDatePicker call.

Expected Behavior

The keyboardType parameter should be respected inside the picker.

Steps To Reproduce

run example with this date picker.

FormBuilderDateTimePicker(
        keyboardType: TextInputType.text,
        inputType: InputType.date,
      );
      ```

### Aditional information

_No response_
@Brunobnahorny
Copy link
Contributor Author

The proposed change could affect existing package users, since the default value for keyboardType is TextInputType.text;

I think the removal of the default value should prevent any breaking changes for those who did not set a value.

@deandreamatias deandreamatias added the good first issue Good for newcomers label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
2 participants