Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FormBuilderTextField): #1334 set enableSuggestions default to true #1406

Merged
merged 1 commit into from
Jun 18, 2024
Merged

feat(FormBuilderTextField): #1334 set enableSuggestions default to true #1406

merged 1 commit into from
Jun 18, 2024

Conversation

LouisHaftmann
Copy link
Contributor

@LouisHaftmann LouisHaftmann commented Jun 18, 2024 •
edited by deandreamatias
Loading

Solution description

This sets the default of enableSuggestions on FormBuilderTextField to true. This is also the default of the normal TextField widget. (see https://api.flutter.dev/flutter/material/TextField/enableSuggestions.html)

Close #1334
Close #1369
Close #1375

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme
@deandreamatias deandreamatias changed the title feat(FormBuilderTextField): set enableSuggestions default to true Jun 18, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.85%. Comparing base (acb7364) to head (901e7e9).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1406   +/-   ##
=======================================
  Coverage   87.85%   87.85%           
=======================================
  Files          21       21           
  Lines         766      766           
=======================================
  Hits          673      673           
  Misses         93       93

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
@deandreamatias deandreamatias merged commit 2771019 into flutter-form-builder-ecosystem:main Jun 18, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@LouisHaftmann @deandreamatias