Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: check built files don't contain external dependencies #371

Open
jzaefferer opened this issue Dec 19, 2014 · 1 comment
Open

Build: check built files don't contain external dependencies #371

jzaefferer opened this issue Dec 19, 2014 · 1 comment
Labels
help wanted

Comments

@jzaefferer
Copy link
Contributor

We just dealt with failures in functional tests that turned out to be caused by cldr/supplemental being added as a dependecy in one place, but not properly included in the build in a different place (requirejs build configuration, exclude option).

To make it easier to spot this kind of issue, we should write a build task that looks at files built in dist/ and throws an error if any file contains the Cldrjs library, or any other always-excluded dependency.
@rxaviers
Copy link
Member

This also extends to any external dependency. So, this also could apply to messageformat.js and make-plural.js
@rxaviers rxaviers changed the title Add a build step that checks built files don't contain cldrjs Dec 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted
2 participants
@jzaefferer @rxaviers