Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Use Sinon.js instead of FakeDate #383

Closed
wants to merge 1 commit into from
Closed

Test: Use Sinon.js instead of FakeDate #383

wants to merge 1 commit into from

Conversation

rxaviers
Copy link
Member

Note: lolex's 3664eb8d90dd1d6fa04a098f77b77b19a6bb5850 sha corresponds
to its 1.1.0 npm version (version is present on npm, but not git tagged
accordingly).

Ref #374
Fixes #382
@rxaviers
Test: Use Sinon.js instead of FakeDate
068f72b 
Note: lolex's 3664eb8d90dd1d6fa04a098f77b77b19a6bb5850 sha corresponds
to its 1.1.0 npm version (version is present on npm, but not git tagged
accordingly).

Ref #374
Fixes #382
@jzaefferer
Copy link
Contributor

Have you verified that sinon and its dependencies use AMD properly?
@rxaviers
Copy link
Member Author

I had and it said it would.
@jzaefferer
Copy link
Contributor

Is there a ticket for getting that tag-free commit tagged properly?
@rxaviers
Copy link
Member Author

I've noticed it's tagged as 1.1.10 in the repo. But, as 1.1.0 in npm.
@jzaefferer
Copy link
Contributor

Looks like the latest version, 1.2.1, is tagged and published, can you use that?
@rxaviers
Copy link
Member Author

Can we? Good question. Sinon.js latest release is 1.12.2, which uses lolex@1.1.0 (i.e., 1.1.10 or 3664eb). I would use lolex@1.2.1 when there's a newer Sinon.js release explicitly telling us to use it.
@rxaviers
Copy link
Member Author

cc @cjohansen
@jzaefferer
Copy link
Contributor

Seems easy enough to test.
@cjohansen
Copy link

Feel free to use Lolex 1.2.1. Sinon master is using it with no problems.
@rxaviers
Copy link
Member Author

Thanks
@rxaviers rxaviers mentioned this pull request Oct 10, 2015
Open
@rxaviers
Copy link
Member Author

Closing. Anyone, feel free to continue my work.
@rxaviers rxaviers closed this Oct 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@rxaviers @jzaefferer @cjohansen